Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable keys with dots! #1077

Merged
merged 1 commit into from
Jan 4, 2021
Merged

feat: enable keys with dots! #1077

merged 1 commit into from
Jan 4, 2021

Conversation

nassiharel
Copy link
Contributor

@nassiharel nassiharel commented Jan 4, 2021 •
edited by maty21
Loading

This change is Reviewable

@nassiharel nassiharel requested a review from yehiyam January 4, 2021 08:43
@nassiharel nassiharel linked an issue Jan 4, 2021 that may be closed by this pull request
fail to store algorithim with node selector '{"error":{"code":500,"message":"key kubernetes.io/hostname must not contain '.'"}}' #1076
Closed
yehiyam
yehiyam approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@nassiharel nassiharel merged commit e77345f into master Jan 4, 2021
@nassiharel nassiharel deleted the keys.with.dots branch January 4, 2021 08:58
hkube-ci pushed a commit that referenced this pull request Jan 4, 2021
@actions-user
feat: enable keys with dots! (#1077) .... bump version [skip ci]
6650e5c
hkube-ci pushed a commit that referenced this pull request Jan 4, 2021
@actions-user
feat: enable keys with dots! (#1077) .... bump version [skip ci]
2987da4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yehiyam yehiyam yehiyam approved these changes

Assignees
No one assigned
Labels
HKube: API-Server
Projects
None yet
Milestone
No milestone
2 participants
@nassiharel @yehiyam